[BUGFIX] keep origin as authority in replacePath#21497
Closed
ubeddulla wants to merge 1 commit into
Closed
Conversation
Contributor
|
thank you for your PR! However, this function is both private, and only used in tests, so I've removed it here: #21499 thanks for finding this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replacepath in @ember/routing lib documents that it prepends location.origin to prevent redirecting to a different origin, and util_test asserts exactly that, but it joins path onto the origin with no separator. a path that does not start with a slash gets reparsed into the authority: origin
http://app.complus@evil.combecomeshttp://app.com@evil.com, so the app's own host turns into userinfo and evil.com becomes the host. the existing test only exercises//google.com, which stays same-origin and hides this. forcing a leading slash before the concat keeps the origin as the authority for every input, and the test now covers the@case too.