Repository navigation
Remove the classic Component from the release guides (RFC 1216) - #2251
Merged
NullVoxPopuli merged 1 commit intoNov 17, 2026
Merged
NullVoxPopuli merged 1 commit into
NullVoxPopuli merged 1 commit into
Conversation
RFC ember-learn#1216 deprecates the classic Component from @ember/component (deprecation id ember-component, available 7.6.0, until 8.0.0). - TypeScript legacy page: drop the "Classic Ember Components" section and the computed callback-form example built on Component.extend. The decorator-form computed example now uses a plain native class, imports computed from @ember/object, and fixes the broken template literal. - TypeScript invokables page: drop the "Classic Ember Components" pointer section. - Accessibility addons list: drop ember-component-focus, a mixin for classic components. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
the TypeScript section may need re-doing, because the whole legacy page is about to be deleted, basically with how much we're deprecating |
11 of 15 tasks
kategengler
approved these changes
Nov 16, 2026
NullVoxPopuli
enabled auto-merge
November 16, 2026 16:21
NullVoxPopuli
disabled auto-merge
November 16, 2026 22:39
NullVoxPopuli
enabled auto-merge
November 16, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last teaching of the classic
Component(the default export of@ember/component) fromguides/release. RFC 1216 deprecates it: emberjs/rfcs#1227typescript/additional-resources/legacy.md: removes the "Classic Ember Components" section and the computed "Callback form" subsection, whose only example wasComponent.extend. The decorator computed example now uses a plain class, with its import and template literal fixed.typescript/core-concepts/invokables.md: removes the section that only linked to the one above.accessibility/application-considerations.md: removes theember-component-focusbullet, a mixin for classic components.Not changed, because these exports are not deprecated:
InputandTextareafrom@ember/component, and@ember/component/helper.Checks:
pnpm lint:mdandpnpm test:node(with the internal link checker) pass.🤖 Generated with Claude Code