Skip to content

Bump simple-git from 3.19.0 to 4.0.2 - #104

Open
matthewhartstonge wants to merge 1 commit into
ember-cli-deploy:masterfrom
matthewhartstonge:chore/deps-simple-git
Open

matthewhartstonge wants to merge 1 commit into
ember-cli-deploy:masterfrom
matthewhartstonge:chore/deps-simple-git

Conversation

@matthewhartstonge

@matthewhartstonge matthewhartstonge commented Oct 19, 2026 •

Copy link
Copy Markdown

What Changed & Why

Resolves CVE-2026-102828 (GHSA-x6jw-m9v5-85vh)

  • One question around node versioning as per the issue.
  • Other thing noted here is that with v4 GIT_* envvars are now silently removed from the git child process unless they're listed in allowEnvironment. But that's not currently configured... would need the following addition if we want it:
simpleGit({
  baseDir: _this.path,
  allowEnvironment: ['GIT_DIR', 'GIT_WORK_TREE']
})

Related issues

#102

PR Checklist

  • Add tests (tests pass)
  • Add documentation (none needed? mayhaps around ENVvars?)
  • Prefix documentation-only commits with [DOC]

People

@lukemelia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant