Repository navigation
Reconnect when the connection drops during a handle_connect query - #805
Merged
josevalim merged 1 commit intoOct 28, 2026
Merged
Conversation
Signed-off-by: Don Yin <Don_Yin@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the query returned from
handle_connect/1lost its connection,handle_event(:internal, {:connect, _}, ...)only matched{:keep_state, state, _}frommaybe_handle/4and dropped its actions, so the reconnect never happened and the process stayed up without receiving notifications. I now return whatmaybe_handle/4gives back, and added a test whosehandle_connect/1terminates its own backend.Fixes #800
The full suite passes locally.