Repository navigation
fix: sync with elide project export, falling back to elide manifest - #18
Merged
Merged
Conversation
Elide 1.6.0 removed `elide manifest`; `elide project export` prints the same JSON. Sync now calls `project export` and falls back to `manifest` when the CLI rejects the subcommand as unrecognized (exit 2), which is how Elide 1.5.x answers. Signed-off-by: Sam Gammon <sam@elide.dev>
Sam Gammon (sgammon)
requested a review
from Dario Valdespino (darvld)
as a code owner
October 12, 2026 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sync reads the project model with
elide project export, falling back toelide manifestwhen the CLI does not have the export command.Why
Elide 1.6.0 removed
elide manifest(elide manifest: removed; use `elide project export` instead, exit 2), so sync failed on 1.6.0 withelide manifest failed (exit 2).elide project exportprints the same JSON.How
ElideCli.manifest()runselide project export [-f …]first. If it fails with exit 2 andunrecognized subcommandon stderr (how Elide 1.5.x answers, see below), it reruns aselide manifest [-f …]. Any other failure is reported as before. The export attempt's stderr is held back and replayed unless the fallback runs, so older Elide does not leave a usage error in the output channel. Docs, the walkthrough and the untrusted-workspace description now nameelide project export.Verification
Real binaries on
samples/ktjvmand fourtools/demos/fixturesprojects from the Elide repo (jvm-test,project-build,test,install):elide project exportelide manifestelide manifest: removed; use `elide project export` insteadelide manifest: removed; use `elide project export` insteaderror: unrecognized subcommand 'export'+ usageerror: unrecognized subcommand 'export'+ usageproject exporton both 1.6 builds andmanifeston 1.5.4 print byte-identical output (cmp) on all five projects.bun run build,bun run --filter elide typecheck,bun run test(130 pass),bun run --filter elide package.packages/core/test/elide.test.tsuse stand-in CLIs with the exit codes and stderr of the real 1.6 and 1.5 binaries: export on 1.6, fallback on 1.5 with the usage error hidden, and an unrelated export failure that is reported without a fallback. The workspace fake CLI now answersproject exportthe way 1.6 does.buildProjectModels(the full sync: version, manifest, install, classpath, JDK) againstsamples/ktjvmwith 1.6.0-rc.2, 1.6.0+00c7bd2a2 and 1.5.4 all producektjvm-sample.main/ktjvm-sample.testwith no warnings.Closes #15