Repository navigation
fix(rbe): pin BuildBuddy RBE to managed executors - #88
Merged
Merged
Conversation
Sam Gammon (sgammon)
requested review from
a team and
Dario Valdespino (darvld)
and
a balanced review from Copilot
October 18, 2026 02:59
There was a problem hiding this comment.
🟢 Approval recommended
Both changes directly implement the stated fix, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Pins both RBE platforms to BuildBuddy’s managed executors, avoiding failures caused by an empty self-hosted pool.
Changes:
- Sets
use-self-hosted-executorsto"false"in both platforms. - Documents why the organization default must be overridden.
| File | Description |
|---|---|
| tools/platforms/BUILD.bazel | Pins the main RBE platform to managed executors. |
| e2e/rbe/tools/platforms/BUILD.bazel | Applies the same setting to the end-to-end RBE platform. |
Review effort: Balanced
Set use-self-hosted-executors=false on the RBE platforms. Its default comes from the BuildBuddy org settings; with the org defaulting to self-hosted, every remote action failed to schedule with 'No registered executors in pool ""'.
Sam Gammon (sgammon)
force-pushed
the
fix/rbe-managed-executors
branch
from
October 18, 2026 03:02
aaa3b22 to
f145d9d
Compare
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rbe (BuildBuddy)job has failed on every PR since ~Oct 11 with:The repo config hasn't changed since it last passed (Sept 18), and rotating
BUILDBUDDY_API_KEYdidn't help. BuildBuddy'suse-self-hosted-executorsexec property picks between the org's self-hosted executors and BuildBuddy's managed pool, and its default comes from org settings. With the org defaulting to self-hosted, actions are sent to an empty self-hosted pool.This sets
use-self-hosted-executors: falseon both RBE platforms (//tools/platformsande2e/rbe/tools/platforms) so this repo always uses BuildBuddy's managed executors.