Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion comments.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
printf( esc_html_x( 'One Response', 'comments title', 'hello-elementor' ) );
} else {
printf(
/* translators: %s: Number of comments. */
esc_html(
/* translators: %s: Number of comments. */
_nx(
'%s Response',
'%s Responses',
Expand Down
7 changes: 4 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"require-dev": {
"squizlabs/php_codesniffer": "^3.6",
"dealerdirect/phpcodesniffer-composer-installer": "^0.7.1",
"wp-coding-standards/wpcs": "^2.3",
"wp-coding-standards/wpcs": "3.3.0",
"phpunit/phpunit": "^9.6.33",
"elementor/elementor-editor-testing": "0.0.3",
"yoast/phpunit-polyfills": "^1.0.1"
Expand All @@ -20,8 +20,9 @@
}
},
"scripts": {
"lint:php": "vendor/bin/phpcs --extensions=php --standard=./phpcs.xml --ignore=node_modules,vendor,assets,tmp -p .",
"lint:php:fix": "vendor/bin/phpcbf --extensions=php --standard=./phpcs.xml --ignore=node_modules,vendor,assets,tmp .",
"lint:php": "vendor/bin/phpcs --standard=./phpcs.xml",
"lint:php:fix": "vendor/bin/phpcbf --standard=./phpcs.xml",
"lint:php:report": "vendor/bin/phpcs --standard=./phpcs.xml --report=summary",
"test": "phpunit --testsuite hello-elementor",
"test:install": "bash ./bin/install-wp-tests-local.sh"
}
Expand Down
228 changes: 209 additions & 19 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion includes/script.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function enqueue() {
$asset_url = HELLO_THEME_SCRIPTS_URL;

if ( ! file_exists( $asset_path ) ) {
throw new \Exception( $asset_path . ' - You need to run `npm run build` for the "hello-elementor" first.' );
throw new \Exception( $asset_path . ' - You need to run `npm run build` for the "hello-elementor" first.' ); // phpcs:ignore WordPress.Security.EscapeOutput.ExceptionNotEscaped
}

$script_asset = require $asset_path;
Expand Down
2 changes: 2 additions & 0 deletions includes/settings/settings-footer.php
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ protected function register_tab_controls() {
'alert_type' => 'info',
'heading' => esc_html__( 'There are no menus in your site.', 'hello-elementor' ),
'content' => sprintf(
/* translators: %s: Link that opens the menus screen. */
__( 'Go to <a href="%s" target="_blank">Menus screen</a> to create one.', 'hello-elementor' ),
admin_url( 'nav-menus.php?action=edit&menu=0' )
),
Expand All @@ -595,6 +596,7 @@ protected function register_tab_controls() {
'type' => Controls_Manager::ALERT,
'alert_type' => 'info',
'content' => sprintf(
/* translators: %s: Link that opens the menus screen. */
__( 'Go to the <a href="%s" target="_blank">Menus screen</a> to manage your menus. Changes will be reflected in the preview only after the page reloads.', 'hello-elementor' ),
admin_url( 'nav-menus.php' )
),
Expand Down
2 changes: 2 additions & 0 deletions includes/settings/settings-header.php
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,7 @@ protected function register_tab_controls() {
'alert_type' => 'info',
'heading' => esc_html__( 'There are no menus in your site.', 'hello-elementor' ),
'content' => sprintf(
/* translators: %s: Link that opens the menus screen. */
__( 'Go to <a href="%s" target="_blank">Menus screen</a> to create one.', 'hello-elementor' ),
admin_url( 'nav-menus.php?action=edit&menu=0' )
),
Expand All @@ -611,6 +612,7 @@ protected function register_tab_controls() {
'type' => Controls_Manager::ALERT,
'alert_type' => 'info',
'content' => sprintf(
/* translators: %s: Link that opens the menus screen. */
__( 'Go to the <a href="%s" target="_blank">Menus screen</a> to manage your menus. Changes will be reflected in the preview only after the page reloads.', 'hello-elementor' ),
admin_url( 'nav-menus.php' )
),
Expand Down
2 changes: 1 addition & 1 deletion index.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
if ( ! $is_elementor_theme_exist || ! elementor_theme_do_location( 'archive' ) ) {
get_template_part( 'template-parts/search' );
}
} else {
} else { // phpcs:ignore Universal.ControlStructures.DisallowLonelyIf.Found
if ( ! $is_elementor_theme_exist || ! elementor_theme_do_location( 'single' ) ) {
get_template_part( 'template-parts/404' );
}
Expand Down
1 change: 0 additions & 1 deletion modules/admin-home/components/settings-controller.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public function apply_setting( $setting, $tweak_callback ) {
if ( isset( $option ) && ( 'true' === $option ) && is_callable( $tweak_callback ) ) {
$tweak_callback();
}

}

public function apply_settings( $settings_group = self::SETTING_PREFIX, $settings = self::SETTINGS ) {
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@
"lint:css:fix": "wp-scripts lint-style --fix",
"lint:js": "wp-scripts lint-js",
"lint:js:fix": "wp-scripts lint-js --fix",
"lint:php": "composer lint:php",
"lint:php:fix": "composer lint:php:fix",
"lint:php": "composer run lint:php",
"lint:php:fix": "composer run lint:php:fix",
"lint:php:report": "composer run lint:php:report",
"clean:build": "rm -rf assets && rm -rf $npm_package_name",
"build:dir": "npm run clean:build && npm run build:prod && rsync -av --exclude-from=.buildignore . $npm_package_name",
"package": "npm run clean:build && npm run build:prod && rsync -av --exclude-from=.buildignore . $npm_package_name",
Expand Down
Loading
Loading