ci: upload audit findings as an audit-results artifact - #1186
Merged
Conversation
Step summaries are not retrievable via the GitHub API, so also write the same findings markdown to a build artifact named audit-results. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EfUcqpF7XDqWLtYTxU2tuW
Deploying electron-website with
|
| Latest commit: |
510de7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ee1a8fe0.electron-website.pages.dev |
| Branch Preview URL: | https://audit-results-artifact.electron-website.pages.dev |
MarshallOfSound
approved these changes
Aug 6, 2026
MarshallOfSound
marked this pull request as ready for review
August 6, 2026 21:55
dsanders11
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Description of Change
Before: the findings from the Audit Docs Version run were only visible on the workflow run's summary page (
GITHUB_STEP_SUMMARY), which is not retrievable through any GitHub API.After: the same findings are additionally uploaded as a build artifact — a single raw markdown file named
audit-results.md— which is downloadable via the API as raw markdown (no zip archive to unpack). The step summary itself, the console output, and the run's exit code are unchanged.How: immediately before the existing
await core.summary.write()call, the script snapshots the summary buffer withcore.summary.stringify()(this must happen beforewrite(), which empties the buffer) and writes it toaudit-results.md. When the audit fails, the expected-vs-actual SHAs (previously onlyconsole.log'd) are appended to the artifact markdown as well. A newactions/upload-artifactstep (pinned to the same SHA already used elsewhere in this repo,if: always(),if-no-files-found: warn) uploads the file witharchive: false, so the artifact is stored and served as the raw fileaudit-results.mdrather than a zip.Checklist
Generated by Claude Code