Skip to content

fix: replace extract-zip with @electron-internal/extract-zip #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsanders11 merged 3 commits into from
Sep 3, 2026
Merged

fix: replace extract-zip with @electron-internal/extract-zip #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc46ad0
fix: replace extract-zip with @electron-internal/extract-zip
erickzhao Jun 4, 2026
081b6d7
update to latest
erickzhao Sep 3, 2026
681632d
Merge branch 'main' into replace-extract-zip
erickzhao Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ npmMinimalAgeGate: 10080

npmPreapprovedPackages:
- '@electron/*'
- '@electron-internal/*'
- '@electron-forge/*'
- 'electron'
- update-electron-app
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@
"@blueprintjs/core": "^3.36.0",
"@blueprintjs/popover2": "^0.12.2",
"@blueprintjs/select": "^3.15.0",
"@electron-internal/extract-zip": "^1.0.5",
"@electron/fiddle-core": "^2.2.0",
"@octokit/rest": "^22.0.1",
"@sentry/electron": "^7.12.0",
"algoliasearch": "^4.12.0",
"classnames": "^2.2.6",
"electron-squirrel-startup": "^1.0.0",
"extract-zip": "^2.0.1",
"fs-extra": "^9.1.0",
"mobx": "^6.5.0",
"mobx-react": "^7.3.0",
Expand Down
2 changes: 1 addition & 1 deletion src/main/content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ async function prepareTemplate(branch: string): Promise<string> {
// unzip it from the tempfile
console.log(`Content: ${branch} unzipping template`);
await fs.ensureDir(TEMPLATES_DIR);
const { default: extract } = await import('extract-zip');
const { extract } = await import('@electron-internal/extract-zip');
await extract(tempfile, { dir: TEMPLATES_DIR });

// cleanup
Expand Down
9 changes: 8 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,13 @@ __metadata:
languageName: node
linkType: hard

"@electron-internal/extract-zip@npm:^1.0.5":
version: 1.0.5
resolution: "@electron-internal/extract-zip@npm:1.0.5"
checksum: 10c0/d3341937dcb37097fd4927b7e5dfb7cb6b1ba56a42b00d62a55a7a9bbd093545dd8c6711ab39b321b2696d968b2cc32c29ed9d60a1fa6aa1665588e03e60d4e1
languageName: node
linkType: hard

"@electron/asar@npm:^3.2.1":
version: 3.2.17
resolution: "@electron/asar@npm:3.2.17"
Expand Down Expand Up @@ -5316,6 +5323,7 @@ __metadata:
"@electron-forge/plugin-fuses": "npm:8.0.0-alpha.9"
"@electron-forge/plugin-webpack": "npm:8.0.0-alpha.9"
"@electron-forge/publisher-github": "npm:8.0.0-alpha.9"
"@electron-internal/extract-zip": "npm:^1.0.5"
"@electron/devtron": "npm:^2.1.1"
"@electron/fiddle-core": "npm:^2.2.0"
"@electron/fuses": "npm:^2.1.1"
Expand Down Expand Up @@ -5353,7 +5361,6 @@ __metadata:
eslint-plugin-import: "npm:^2.27.5"
eslint-plugin-react: "npm:^7.32.2"
eslint-plugin-tsdoc: "npm:^0.3.0"
extract-zip: "npm:^2.0.1"
fork-ts-checker-webpack-plugin: "npm:^8.0.0"
fs-extra: "npm:^9.1.0"
husky: "npm:^9.0.11"
Expand Down