XMLParser: fix premature stream termination on empty mid-stream reads#16
Merged
Merged
Conversation
stream_get_contents() returns '' (empty string) at EOF, not false, so the previous $isFinal = ($data === false) check never triggered, and an empty read caused the nodesQueue to stay empty and valid() to return false — silently stopping iteration mid-document. Compressed or network streams (e.g. compress.zlib:// over HTTP) can also return '' between internal block boundaries (zlib flush markers, TCP chunk boundaries) without being at EOF. The fix wraps the read loop so parseNextChunk() keeps reading until either at least one node is queued or feof() confirms the stream is truly exhausted, and a streamFinished flag prevents calling xml_parse() on an already-finalised parser. Fixes #13 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream_get_contents()returns '' (empty string) at EOF, not false, so the previous$isFinal = ($data === false)check never triggered, and an empty read caused thenodesQueueto stay empty and valid() to return false — silently stopping iteration mid-document.Compressed or network streams (e.g.
compress.zlib://over HTTP) can also return '' between internal block boundaries (zlib flush markers, TCP chunk boundaries) without being at EOF. The fix wraps the read loop soparseNextChunk()keeps reading until either at least one node is queued orfeof()confirms the stream is truly exhausted, and a streamFinished flag prevents callingxml_parse()on an already-finalised parser.Resolves #13.