Keep ts-morph project reference between watches - #474
Merged
Conversation
🦋 Changeset detectedLatest commit: 1ffb026 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Owner
Author
|
/release-snapshot |
Contributor
|
✅ Snapshot published @eddeee888/gcg-operation-location-migration@0.0.0-pr467-run390-1-20260809065829
@eddeee888/gcg-server-config@0.0.0-pr467-run390-1-20260809065829
@eddeee888/gcg-typescript-resolver-files@0.0.0-pr472-run403-1-20260813130340 |
eddeee888
force-pushed
the
keep-project-reference
branch
from
August 22, 2026 10:47
0c414eb to
4e161f1
Compare
eddeee888
commented
Aug 23, 2026
Comment on lines
+149
to
+162
| // 4. Apply to result files the updated content done in step 2. and 3. above | ||
| sourceFilesToProcess.forEach(({ sourceFile, resolverFile }) => { | ||
| const normalizedRelativePath = path.posix.relative( | ||
| cwd(), | ||
| sourceFile.getFilePath() | ||
| ); | ||
|
|
||
| // Overwrite existing files with fixes | ||
| result.files[normalizedRelativePath] = { | ||
| ...resolverFile, | ||
| content: sourceFile.getText(), | ||
| }; | ||
| }); | ||
| // Overwrite existing files with fixes | ||
| result.files[normalizedRelativePath] = { | ||
| ...resolverFile, | ||
| content: sourceFile.getText(), | ||
| }; | ||
| }); | ||
| } |
Owner
Author
There was a problem hiding this comment.
This was sitting outside of the intended scope so we were running sourceFilesToProcess.forEach twice! i.e. doubling the work
eddeee888
commented
Aug 23, 2026
|
|
||
| export const presetName = '@eddeee888/gcg-typescript-resolver-files'; | ||
|
|
||
| let tsMorphProject: Project; |
Owner
Author
There was a problem hiding this comment.
Keeping a reference so we don't need to re-initialise and type-check files every run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODO
Result
The main impact is on watch triggers, the part that typechecks and generates resolvers is 50% faster
Before
4.11s (total 5.05s)
After
2.29s (total 3.35s)