Skip to content

[2097] Handle expressions in SysON#2225

Open
pcdavid wants to merge 1 commit into
mainfrom
pcd/enh/handle-expressions
Open

[2097] Handle expressions in SysON#2225
pcdavid wants to merge 1 commit into
mainfrom
pcd/enh/handle-expressions

Conversation

@pcdavid
Copy link
Copy Markdown
Contributor

@pcdavid pcdavid commented May 20, 2026 •
edited
Loading

  • [2097] Handle expressions in SysON

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@pcdavid pcdavid force-pushed the pcd/enh/handle-expressions branch from 0f3937f to 30421cd Compare May 20, 2026 14:08
@pcdavid pcdavid changed the base branch from cooldown to pcd/enh/expression-internals-filter May 20, 2026 14:09
@AxelRICHARD AxelRICHARD force-pushed the pcd/enh/expression-internals-filter branch from b8013e2 to 0d62629 Compare May 20, 2026 14:21
Base automatically changed from pcd/enh/expression-internals-filter to cooldown May 20, 2026 15:01
@pcdavid pcdavid force-pushed the pcd/enh/handle-expressions branch 3 times, most recently from 470e4f6 to 8906c7d Compare May 21, 2026 07:58
Base automatically changed from cooldown to main May 21, 2026 09:55
@pcdavid pcdavid force-pushed the pcd/enh/handle-expressions branch from 8906c7d to 7553a4b Compare May 21, 2026 12:10
@pcdavid pcdavid added this to the 2026.7.0 milestone May 21, 2026
@pcdavid pcdavid linked an issue May 21, 2026 that may be closed by this pull request
Handle expressions in SysON #2097
Open
@pcdavid pcdavid force-pushed the pcd/enh/handle-expressions branch 4 times, most recently from 138dc67 to c7a2511 Compare May 22, 2026 07:17
@pcdavid pcdavid marked this pull request as ready for review May 22, 2026 07:17
@pcdavid pcdavid force-pushed the pcd/enh/handle-expressions branch 5 times, most recently from 38c2f7b to 3e7f13d Compare May 27, 2026 09:42
AxelRICHARD
AxelRICHARD reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments to take into account please, thank you for this new feature!

Comment thread frontend/syson-components/src/extensions/NewObjectAsTextDocumentReport.tsx Outdated
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2025 Obeo.
* Copyright (c) 2025, 2026 Obeo.
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for copyright update here

Comment thread frontend/syson-components/src/extensions/SysONExtensionRegistryMergeStrategy.ts Outdated
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2024, 2025 Obeo.
* Copyright (c) 2024, 2026 Obeo.
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for copyright update here

Comment thread ...yson-sysml-import/src/main/java/org/eclipse/syson/sysml/services/SysideExpressionEditor.java
* Extracts the expression and its parent relationship once they have been parsed and linked. This is the reverse of
* {@link #wrapPlainExpression(Element, String)}.
*
* @param roots
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add javadoc for @param and @return annotations, here and everywhere else in this file or other file you modified.

Comment thread ...yson-sysml-import/src/main/java/org/eclipse/syson/sysml/services/SysideExpressionEditor.java Outdated
return Optional.ofNullable(result).stream().toList();
}

private Element extractGuardExpression(StateUsage wrappingState) {
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add javadoc for this method please?

What happens if the wrappingState does not have two relationships?

Comment thread ...-sysml-import/src/main/java/org/eclipse/syson/sysml/services/api/ISysMLExpressionEditor.java
ExpressionCreationResult createExpression(IEMFEditingContext emfEditingContext, Element parentElement, String expressionText);

// "Editing" an expression actually means creating a new one to replace the previous one.
ExpressionCreationResult editExpression(IEMFEditingContext emfEditingContext, Element parentElement, Expression expression, String expressionText);
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you convert that into javadoc please?

Comment thread ...-sysml-import/src/main/java/org/eclipse/syson/sysml/services/api/ISysMLExpressionEditor.java
* @author pcdavid
*/
public interface ISysMLExpressionEditor {
ExpressionCreationResult createExpression(IEMFEditingContext emfEditingContext, Element parentElement, String expressionText);
Copy link
Copy Markdown
Member

@AxelRICHARD AxelRICHARD May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add javadoc please?

@pcdavid pcdavid force-pushed the pcd/enh/handle-expressions branch 2 times, most recently from e64c04e to b6ada90 Compare May 28, 2026 14:00
@pcdavid
[2097] Handle expressions in SysON
2e461b0 
Bug: #2097
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid force-pushed the pcd/enh/handle-expressions branch from b6ada90 to 2e461b0 Compare May 28, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD approved these changes

Assignees

No one assigned

Labels

pr: to review soon priority: high

Projects

None yet

Milestone

2026.7.0

Development

Successfully merging this pull request may close these issues.

Handle expressions in SysON

2 participants

@pcdavid @AxelRICHARD