Replace mmap-based IPC with score_baselibs SharedMemoryFactory in ts_client#54
Merged
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
aad9e21 to
7c692e8
Compare
BjoernAtBosch
suggested changes
Jun 15, 2026
This was referenced Jun 22, 2026
This reverts commit 8c6827d.
This reverts commit ddfbd8b.
lavrovvalera
approved these changes
Jun 30, 2026
antonkri
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hand-rolled POSIX
shm_open/mmapimplementation ints_clientwith
score::memory::shared::SharedMemoryFactoryfromscore_baselibs, andwires up a new
SvtHandlerShmtimebase handler inTimeDaemon.ts_client (
score/ts_client/)GptpIpcPublisher/GptpIpcReceiver: remove directshm_open,mmap,ftruncate,closecalls; useSharedMemoryFactory::Create/SharedMemoryFactory::Openinstead. Memory region is now constructed viaISharedMemoryResource::construct<GptpIpcRegion>().SharedMemoryFactory::Remove+RemoveStaleArtefactsreplace the rawshm_unlinkin publisher init._SRC_segment.TimeDaemon (
score/time_daemon/src/application/svt/)SvtHandlerShm(factory_shm.h/.cpp,svt_handler_shm.h/.cpp):a
TimebaseHandlerimplementation that reads live gPTP data from sharedmemory via
GPTPShmMachineand drives the same verification + IPC-publishpipeline as the existing
SvtHandler.fixes (#41)