Run C++ code formatter in 3 folders#264
Conversation
- examples - score/health_monitor - tests
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| Priority: 1 | ||
| IndentWidth: 4 | ||
| InsertNewlineAtEOF: true | ||
| # InsertNewlineAtEOF: true |
There was a problem hiding this comment.
Why was this commented out?
There was a problem hiding this comment.
I changed it because that line gave an unknown attribute error and searching for it revealed that this was encountered by others as well due to usually outdated clang-format ( under version 12, but ours is above 14 ).
There was a problem hiding this comment.
Shall not be done. Thats not our problem - one need to use correct clang format.
There was a problem hiding this comment.
Devcontainer uses clang-format version 20.1.8 and the .clang-format file works for this version. So I also think this change has to be reverted.
There was a problem hiding this comment.
I will fix this and revert the change in the .clang-format file.
There was a problem hiding this comment.
I reverted the change in the .clang-format file and re-ran the formatting using clang-format 20.1.8.
pawelrutkaq
left a comment
There was a problem hiding this comment.
Shall we integrate eclipse-score/tooling#294. since if we have formatting errors now, does CI job detect formatting issues ? If not, we shall fix CI too with this PR.
I think this would be good to use. Otherwise formatting will diverge again and again if this is not being enforced. |
Fixed .clang-format file Re-run the formatting with clang-format 20.1.8
Run C++ code formatter in 3 folders :