chore: adopt @score_cpp_policies//coverage in communication#604
Open
olivembo wants to merge 2 commits into
Open
chore: adopt @score_cpp_policies//coverage in communication#604olivembo wants to merge 2 commits into
olivembo wants to merge 2 commits into
Conversation
…pstream The coverage tools (merger, reporter, justify, effective_coverage) were maintained as local copies in quality/coverage/llvm_cov/. Now that they live in @score_cpp_policies, this commit wires in the upstream versions. Changes: - MODULE.bazel: add score_cpp_policies dev dependency (git_override pointing to PR eclipse-score#9 (eclipse-score/score_cpp_policies#9), to be replaced with a version tag after merge) - MODULE.bazel: bump aspect_rules_lint 2.3.0 -> 2.5.0 (required by score_cpp_policies) - coverage.bazelrc: switch --coverage_output_generator to @score_cpp_policies//coverage:merger - llvm_cov/BUILD: replace four py_binary targets and the genrule wrapper with score_coverage_reporter + score_instrumented_sources_manifest macros - generate_coverage_html.sh: update justify and effective_coverage invocations to @score_cpp_policies//coverage:* - delete merger.py, reporter.py, justify.py, effective_coverage.py, filter_regexes.txt since all moved upstream - llvm_cov/README.md: updated to reflect the new structure The --coverage_report_generator flag and the reporter_wrapper target name are unchanged, so existing CI scripts need no adjustment.
olivembo
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the local copies of
merger.py,reporter.py,justify.pyandeffective_coverage.pywith the centralized tooling from
@score_cpp_policies//coverage.The
--coverage_report_generatorflag and thereporter_wrappertarget name are unchanged, so existing CI scripts need no adjustment.Changes
score_cpp_policiesas dev dependency viagit_override(PR9 in score_cpp_policies, to be replaced with a version tag after merge); bumpaspect_rules_lint2.3.0 -> 2.5.0--coverage_output_generatorto@score_cpp_policies//coverage:mergerpy_binarytargets and thegenrulewrapper withscore_coverage_reporter+score_instrumented_sources_manifestjustifyandeffective_coverageinvocations to@score_cpp_policies//coverage:*merger.py,reporter.py,justify.py,effective_coverage.py,filter_regexes.txtDepends on
eclipse-score/score_cpp_policies#9 which must be merged and released before the
git_overridecan be replaced with a version tag.