Fix public API breakage#600
Merged
Merged
Conversation
LittleHuba
requested review from
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
bemerybmw
previously approved these changes
Jun 26, 2026
The introduction of getters and setters in fields broke the public API. This change introduces a facade layer that restores the previous behavior of the public API. Since the breakage was intentional in terms of envisioned API, we still plan to migrate to this new API. Therefore, the fix also introduces a deprecation warning. This makes migration for users simpler. This commit can be reverted once we enforce the new API.
bemerybmw
force-pushed
the
ulhu_depr_field
branch
from
815ce23 to
45c6955
Compare
castler
approved these changes
Jun 30, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of getters and setters in fields broke the public API.
This change introduces a facade layer that restores the previous behavior of the public API. Since the breakage was intentional in terms of envisioned API, we still plan to migrate to this new API. Therefore, the fix also introduces a deprecation warning. This makes migration for users simpler.
This commit can be reverted once we enforce the new API.