mw/com: Undo change which breaks binding independence of factories #596
Open
bemerybmw wants to merge 2 commits into
Open
mw/com: Undo change which breaks binding independence of factories #596bemerybmw wants to merge 2 commits into
bemerybmw wants to merge 2 commits into
Conversation
This commit undoes most of the changes to the binding factories added in 5804ab6. This change removed the variant handling in the factory create functions which are needed to support different bindings in mw/com. It also adds ServiceElementType to ProxyEventBindingFactory::Create so that it can be reused by ProxyFieldBindingFactory.
bemerybmw
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit undoes most of the changes to the binding factories added in
5804ab6. This change removed the
variant handling in the factory create functions which are needed to
support different bindings in mw/com.
It also adds ServiceElementType to ProxyEventBindingFactory::Create so
that it can be reused by ProxyFieldBindingFactory.