Retire outdated Migrate Welcome page#2631
Conversation
|
Releng team FYI, since a ~week all verifcation builds fail in eclipse-platform cc @HannesWell cc @merks |
|
For the problem, see the solution in eclipse-jdt/eclipse.jdt.core#5016. |
HannesWell
force-pushed
the
retire-migrate-welcome-page
branch
from
788d0ae to
da798b5
Compare
Fixed via Was harder to spot with the inconsistent state back then. Sorry for the inconvenience. |
There was a problem hiding this comment.
Pull request overview
Removes the outdated “Migrate” page from the Eclipse Platform welcome/intro contributions, including its wiring, styling, and icon assets.
Changes:
- Removes the
migrateentry from the Platform product’s intro root pages and deletes themigratepage definition fromintroData.xml. - Drops intro config extension contributions that previously added migration-related content to the welcome.
- Deletes migration-related intro content files, CSS/properties, and the migrate topic icon, and removes associated styling hooks from “What’s New”.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| platform/org.eclipse.platform/plugin_customization.ini | Removes migrate from Platform product intro root pages. |
| platform/org.eclipse.platform/plugin.xml | Removes intro configExtension contributions for migration-related content. |
| platform/org.eclipse.platform/introData.xml | Removes org.eclipse.ui.workbench.migration extension and deletes the migrate page. |
| platform/org.eclipse.platform/intro/whatsnewExtensionContent3.xml | Deletes “Porting Guide”/migration link intro content. |
| platform/org.eclipse.platform/intro/migrateExtensionContent.xml | Deletes Platform migration page extension content. |
| platform/org.eclipse.platform/intro/css/whatsnew.properties | Removes migration icon properties; normalizes spacing. |
| platform/org.eclipse.platform/intro/css/whatsnew.css | Removes CSS selectors for the migration link/icon. |
| platform/org.eclipse.platform/intro/css/migrate.properties | Deletes migrate page properties. |
| platform/org.eclipse.platform/intro/css/migrate.css | Deletes migrate page CSS. |
| platform/org.eclipse.platform/images/topiclabel/wn_migrate48.svg | Deletes migrate topic icon. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Root page links to show in the Universal Welcome | ||
| org.eclipse.ui.intro.universal/INTRO_ROOT_PAGES = overview,tutorials,samples,whatsnew,migrate | ||
| org.eclipse.ui.intro.universal/INTRO_ROOT_PAGES = overview,tutorials,samples,whatsnew |
There was a problem hiding this comment.
This change removes the "migrate" root page only for the org.eclipse.platform product customization. The SDK (platform/org.eclipse.sdk/plugin_customization.ini) still includes "migrate" in INTRO_ROOT_PAGES, so the Migrate link will remain visible in the IDE build even though the underlying intro wiring/content is being removed in this PR. To fully retire the page as described, remove "migrate" from the SDK’s INTRO_ROOT_PAGES as well (and update the corresponding introData).
| configId="org.eclipse.ui.intro.universalConfig" | ||
| content="$nl$/intro/whatsnewExtensionContent1.xml"/> | ||
| <configExtension | ||
| configId="org.eclipse.ui.intro.universalConfig" | ||
| content="$nl$/intro/whatsnewExtensionContent2.xml"/> |
There was a problem hiding this comment.
The migration-related intro content files (whatsnewExtensionContent3.xml / migrateExtensionContent.xml) are removed here, but the SDK welcome wiring still references them indirectly: platform/org.eclipse.sdk/introData.xml still includes extension id "org.eclipse.ui.workbench.migration" and a "migrate" page referencing extension id "org.eclipse.platform". With these configExtension contributions gone, the SDK welcome will end up with missing/empty sections or unresolved extension content. Either remove those references from the SDK introData/plugin_customization as part of this PR, or keep providing compatible extensionContent for those ids.
The "Migrate" page on the Welcome screen has not been updated since 4.29 and no user complained, so remove it. Porting guides are still maintained in the platform docs and reachable from the help system. Fixes eclipse-platform#2630
vogella
force-pushed
the
retire-migrate-welcome-page
branch
from
da798b5 to
2f9d794
Compare
|
Good catch — applied the same removal to |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The "Migrate" page on the Eclipse Welcome screen has not been updated since 4.29 and no user has complained, so this removes it together with its CSS, properties, icon, and intro data wiring. The actual porting guides remain available through the platform documentation and the help system, which is the more durable place to surface them.
Fixes #2630