Collapse inline Status allocations to ILog.of(Class) log sites#2628
Collapse inline Status allocations to ILog.of(Class) log sites#2628vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Replace Plugin.getDefault().getLog().log(new Status(...)) with ILog.of(MyClass.class).error(...) / .log(status) in non-activator classes to drop the activator round-trip and the Status allocation where applicable. Only touches sites where the class and the previously-used activator live in the same bundle, so log attribution is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Test Results 51 files ±0 51 suites ±0 36m 13s ⏱️ -53s For more details on these failures, see this check. Results for commit ccff05f. ± Comparison against base commit 9e8a07f. |
|
Build failure looks unrelated: Error: Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:5.0.3-SNAPSHOT:test (default-test) on project org.eclipse.core.tests.resources.saveparticipant1: No tests found -> [Help 1] |
1 participant
Summary
Replaces
Plugin.getDefault().getLog().log(new Status(...))withILog.of(MyClass.class).error(...)/.log(status)in non-activator classes, dropping the activator round-trip and theStatusallocation where applicable. Follow-up to the counterpart cleanup in eclipse-platform/eclipse.platform.ui.Scope of this PR is intentionally narrow: only sites where the class and the previously-used activator live in the same bundle, so log attribution is unchanged. Remaining sites (activator static
log()helpers, utilityLogclasses, cross-bundle attribution, etc.) are deferred to follow-up PRs so each category can be reviewed on its own merits.Files touched (9):
debug/org.eclipse.debug.examples.core—PDADebugTargetterminal/org.eclipse.terminal.connector.local—LocalLauncherDelegateterminal/org.eclipse.terminal.view.ui—PreferencePage,TerminalsView,AbstractAction,NewTerminalViewAction,AbstractTriggerCommandHandler,InputStreamMonitor,OutputStreamMonitorContext: vogellacompany/tasks#1837
Test plan
mvn clean verify -Pbuild-individual-bundleson each affected bundle.logwith the expected bundle id