fix: Draw terminal characters individually to prevent clipping with f…#2614
Closed
astrograph wants to merge 1 commit intoeclipse-platform:masterfrom
Closed
fix: Draw terminal characters individually to prevent clipping with f…#2614astrograph wants to merge 1 commit intoeclipse-platform:masterfrom
astrograph wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
…ractional DPI scaling On Windows with fractional DPI scaling (125%, 150%), SWT/GDI accumulates sub-pixel rounding when drawing a whole string, causing glyphs to overflow their grid cells. Draw each character at its exact cell position instead.
astrograph
force-pushed
the
fix/terminal-dpi-clipping
branch
from
71dce6f to
866daba
Compare
Contributor
Member
|
Is this related to #2617? Does drawing characters individually have any (negative?) effect on performance? |
Contributor
|
Please add a proper description of the issue and how to reproduce it. To me this looks like a solution to an already solved issue, see: #2617 (comment). |
Contributor
|
@astrograph can you please add information on reproduction or the issue and check if the issue is already resolved in the latest development state? |
Contributor
Author
|
thank you for the feedback, I will reassess after we consumed the current release! |
Contributor
Testing before a release is a much better idea than testing after a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ractional DPI scaling
On Windows with fractional DPI scaling (125%, 150%), SWT/GDI accumulates sub-pixel rounding when drawing a whole string, causing glyphs to overflow their grid cells. Draw each character at its exact cell position instead.