Skip to content

Remove 2018 deprecated runtime contenttype extension point#1644

Open
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella:delete-deprecated-extension-point
Open

Remove 2018 deprecated runtime contenttype extension point#1644
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella:delete-deprecated-extension-point

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Nov 27, 2024

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

@HannesWell
Copy link
Copy Markdown
Member

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

eclipse-platform-bot commented Nov 27, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From dae5e5bd99a2041de3a6b5282301fa0fa28ff0b1 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 12 May 2025 06:49:44 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index d7ec81e54a..ed76b75691 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.33.0.qualifier
+Bundle-Version: 3.33.100.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Nov 27, 2024

Awesome @HannesWell that works. Thank you for the tip

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Nov 27, 2024

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

Will do.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 27, 2024

Test Results

 1 683 files   -  81   1 683 suites   - 81   1h 41m 34s ⏱️ + 11m 57s
 4 228 tests  - 153   4 198 ✅  - 158   24 💤 ±0   6 ❌ + 5 
12 684 runs   - 459  12 499 ✅  - 476  167 💤 ±0  18 ❌ +17 

For more details on these failures, see this check.

Results for commit 4991a2f. ± Comparison against base commit babaec5.

This pull request removes 153 tests.
AllCompareTests AsyncExecTests ‑ testCancelOnRequeue
AllCompareTests AsyncExecTests ‑ testQueueAdd
AllCompareTests AsyncExecTests ‑ testWorker
AllCompareTests CompareFileRevisionEditorInputTest ‑ testPrepareCompareInputWithNonLocalResourceTypedElements
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptorForTextType_StreamAccessor
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptor_TextType_NotStreamAccessor
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptor_UnknownType
AllCompareTests ContentMergeViewerTest ‑ testFFFX
AllCompareTests ContentMergeViewerTest ‑ testFFTX
AllCompareTests ContentMergeViewerTest ‑ testFFXF
…

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the delete-deprecated-extension-point branch from 655204f to e25e5b0 Compare November 28, 2024 04:56
@vogella vogella force-pushed the delete-deprecated-extension-point branch from e25e5b0 to c2d7645 Compare January 14, 2025 10:46
In 2018 we marked this extension point for deletion, lets remove it for
2025-03.
@vogella vogella force-pushed the delete-deprecated-extension-point branch from c2d7645 to 62ddc9c Compare May 12, 2025 06:45
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 26, 2026

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 26, 2026

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 26, 2026

#2633

@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 26, 2026

Removals are best done for M1 and not M3

vogella added a commit to eclipse-platform/eclipse.platform.ui that referenced this pull request Apr 26, 2026
The org.eclipse.core.runtime.contentTypes extension point is being
removed in eclipse-platform/eclipse.platform#1644. Update the two
remaining test fixtures (regression test for bug 107121 in
OpenNavigatorFolderTest, and ObjectContributionTest) to contribute to
org.eclipse.core.contenttype.contentTypes instead.
vogella added a commit to eclipse-platform/eclipse.platform.ui that referenced this pull request Apr 26, 2026
The org.eclipse.core.runtime.contentTypes extension point was removed
in eclipse-platform/eclipse.platform#1644. Update schema documentation
to reference the non-deprecated org.eclipse.core.contenttype.contentTypes
extension point instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants