Use dialog font in editor drop-down and drop bold-when-hidden marker#3940
Use dialog font in editor drop-down and drop bold-when-hidden marker#3940vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
The editor chevron drop-down inherited the SWT system font, which on
many platforms looks out of place compared to the rest of the IDE
chrome. Switch the filter text and the table to JFaceResources
getDialogFont() so the list matches the Quick Switch Editor (Ctrl+E)
dialog and other workbench dialogs.
Also remove the rule in BasicStackListLabelProvider that rendered an
entry in bold when its CTabItem was not currently visible in the tab
bar. That marker is not useful to users:
- It is undiscoverable. There is no legend or tooltip explaining
that bold means "tab scrolled off the visible tab bar". Bold
conventionally signals importance, unread, or modified, none of
which apply here.
- It is redundant with why the drop-down is opened. Users open the
chevron precisely because some tabs do not fit. Encoding which
rows overflowed burns the strongest typographic emphasis on
information the user did not ask for.
- It crowds out more meaningful styling. PR eclipse-platform#3938 introduces bold
for matched filter substrings, which is a far more useful signal
and conflicted visually with the previous all-bold rows.
|
Old: 
New (light): 
New (dark): 
The existing CTRL+E style which is unchanged would also in line with the new font 
|
|
You are mixing two changes. The font size and the bold-stuff. I think the one thing (size) is clear. The other one can be discussed. Should this be split into two PRs? |
I do not change the font size in this PR, please check the code. It looks bigger because it is bold (and not the dialog font) |
|
But your PR text say:
|
Yes, that is also what I said here: It looks bigger because it is bold (and not the dialog font) |
|
I can't spot a difference because every old/new pair of screenshots shows different dialogs, and the light one shows even dark mode??? Sorry, it just wastes everyone time. Can you please provide clean side by side examples before / after? |
|
Leave the bolding. It is important information, and I rely on it quite frequently. I find it very useful to see immediately which of the items is in a visible tab. |
Correct. If this is not in Ctrl+E it should be added there, not otherwise. |
So you need a visual distinction between open and not open. I see if I can come up with something that serves this purpose and does not look misplaced in the current ui (or even ugly) to me. I will copy you in the PR if I create one and will wait for your feedback. |
4 participants
The chevron drop-down on editor stacks inherited the SWT system font, which on many platforms looks out of place compared to the rest of the IDE chrome. This change switches both the filter text and the result table to
JFaceResources.getDialogFont()so the list matches the Quick Switch Editor (Ctrl+E) dialog.It also removes the rule that rendered an entry in bold when its
CTabItemwas not currently visible in the tab bar. That marker is undiscoverable (no legend, and bold conventionally signals importance/unread/modified, none of which apply), redundant with why the drop-down is opened in the first place, and visually conflicted with the more useful match highlighting introduced in #3938.