Drop dead log(Exception) helper in WorkbenchActivitySupport#3935
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom Apr 24, 2026
Merged
Drop dead log(Exception) helper in WorkbenchActivitySupport#3935vogella merged 1 commit intoeclipse-platform:masterfrom
vogella merged 1 commit intoeclipse-platform:masterfrom
Conversation
The private log(Exception) method built an IStatus and discarded it, never actually logging anything. It has been broken since it was introduced in 2004. The only caller swallows InvocationTargetException and InterruptedException from ProgressMonitorDialog.run(); inline that swallow with a comment explaining why the interrupt flag is not re-set (ModalContext.run uses InterruptedException to signal cancellation, not actual thread interruption). Fixes eclipse-platform#3915
Contributor
tomaswolf
approved these changes
Apr 24, 2026
Contributor
Author
|
Thanks @tomaswolf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private
log(Exception)helper built anIStatusand immediately discarded it, never actually logging anything. It has been broken since it was introduced in 2004. Inline the exception swallow at the single call site with a comment explaining why the interrupt flag is not re-set (per @tomaswolf,ModalContext.runusesInterruptedExceptionto signal cancellation, not actual thread interruption).Fixes #3915