Skip to content

Better button styling in workspace selection dialog #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogella merged 1 commit into from
May 1, 2026
+10 −0
Merged

Better button styling in workspace selection dialog #3918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...clipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import org.eclipse.swt.SWT;
import org.eclipse.swt.graphics.Color;
import org.eclipse.swt.layout.FillLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Display;
Expand Down Expand Up @@ -945,6 +946,15 @@ private void applyDarkStyles(Shell shell) {
}

private void applyStylesRecursive(Control control, Color bg, Color fg, Color linkColor) {
if (control instanceof Button button) {
// On Windows, check buttons need an explicit background; otherwise they
// appear white because the parent background is not inherited.
if (Platform.OS_WIN32.equals(Platform.getOS()) && (button.getStyle() & SWT.CHECK) != 0) {
button.setBackground(bg);
}
// Leave other buttons unstyled so the native dark appearance is used
return;
}
control.setBackground(bg);
if (control instanceof Link link) {
link.setLinkForeground(linkColor);
Expand Down
Loading