fix: mprotocol should be initialized - #9
Merged
Conversation
al3xwq
force-pushed
the
develop-2.4.2
branch
from
September 2, 2025 22:19
49377f8 to
8f34cca
Compare
|
|
||
| if (!mTerminal->isConnected()) { | ||
| temporaryConnection = true; | ||
| mTerminal->openAndConnect("DIRECT"); |
Contributor
There was a problem hiding this comment.
It would make more sense to use PcscReader::IsoProtocol::DIRECT.getValue() instead of "DIRECT"?
al3xwq
force-pushed
the
8-mprotocol-should-be-initialized
branch
from
September 17, 2025 22:56
4b9cfd4 to
5a35b6e
Compare
al3xwq
force-pushed
the
8-mprotocol-should-be-initialized
branch
from
September 17, 2025 22:59
5a35b6e to
f92ce09
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.