fix(templates): a moved document line resums the vacated document from the full-row paths too, and the relation picker stays a task-form control - #6872
Merged
Conversation
…m the full-row paths too, and the relation picker stays a task-form control (#6863, #6866) Two residues of the 2026-08-19 wave, found in its review: - #6840 closed the moved-line hole for the TARGETED write paths; the full-row update() and updateWithoutEvent still resummed only the document the line points at NOW. A REST PUT re-pointing a line's FK - the most ordinary write there is - left the vacated document displaying, printing and POSTING a total that did not equal the sum of its lines. Both paths now read the before-FK through the BASE find (the history before-image's convention) and resum both documents when the line moved. Closes #6863. - The relation picker (#6849) locates its option list through the __<Fk>EntityUrl / __<Fk>EntityLabel process variables the trigger seeds, which exist only on a task form - but the generator's branch was reachable from a NON-task form listing a bare to-one relation in fields:, where isReadonlyByDefault(null) reads false and an editable, permanently-empty select replaced the text control that at least showed the raw key. The picker branch is now gated on the task form, with a fixture-surgery-guarded regression test. Closes #6866. Verified by ModelGenerationIT (render + blank-line guard), IntentEngineIT and IntentEmissionCoverageIT, plus the engine-intent unit suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6863 and #6866 — the two generated-output residues of the 2026-08-19 wave review.
update()andupdateWithoutEventin the generated document-line repository now capture the before-FK (throughsuper.findById, the history before-image's convention) and resum both documents when the line moved — completing what A targeted write to a document line resums the master #6840 did for the targeted paths. Before this, a plain REST PUT re-pointing a line's FK left the vacated document with a stale total.FormIntentGeneratorchooses the relation picker only on a task form — the control locates its options through process variables the trigger seeds, which exist nowhere else. A non-task form listing a bare to-one relation keeps the plain text control instead of an editable select that stays permanently empty. Regression test guards the fixture surgery against vacuous passes.Verified:
ModelGenerationIT(render + consecutive-blank-lines guard),IntentEngineIT56/56,IntentEmissionCoverageIT, engine-intent unit suite 759+.🤖 Generated with Claude Code