feat(dialect): render types from the JDBC type, not the model name - #42
Merged
Merged
Conversation
nativeType asks the JDBC type instead of the model's type name, so a model may say BOOLEAN or CHARACTER VARYING and each database still gets a spelling it accepts. NUMERIC and DECIMAL stay distinct. New hooks: booleanTypeName, timestampTypeName, bigintTypeName, createTableSuffix, analyzeSchema, analyzeTable, supportsTransactions. Filled in: BOOLEAN as SMALLINT (duckdb, derby, oracle, sqlite, clickhouse), TINYINT(1) (mysql, mariadb), BIT (mssql); TIMESTAMP as DATETIME (mysql, mariadb, mssql); BIGINT as DECIMAL(15,0) with one-row inserts on oracle; MergeTree and Nullable(T) on clickhouse; ANALYZE on h2 and postgres. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nativeType asks the JDBC type instead of the model's type name, so a model may say BOOLEAN or CHARACTER VARYING and each database still gets a spelling it accepts. NUMERIC and DECIMAL stay distinct.
New hooks: booleanTypeName, timestampTypeName, bigintTypeName, createTableSuffix, analyzeSchema, analyzeTable, supportsTransactions.
Filled in: BOOLEAN as SMALLINT (duckdb, derby, oracle, sqlite, clickhouse), TINYINT(1) (mysql, mariadb), BIT (mssql); TIMESTAMP as DATETIME (mysql, mariadb, mssql); BIGINT as DECIMAL(15,0) with one-row inserts on oracle; MergeTree and Nullable(T) on clickhouse; ANALYZE on h2 and postgres.