Open
Conversation
# Conflicts: # src/cmem/ContentBlobToggler/StringPreviewContentBlobToggler.tsx
haschek
requested changes
Feb 5, 2026
| : depiction instanceof HTMLElement | ||
| ? <>{depiction.outerHTML}</> | ||
| : depiction} | ||
| </span> |
Member
There was a problem hiding this comment.
Why should land a HTMLElement here?
Contributor
There was a problem hiding this comment.
This is how the depiction parameter has been defined years ago. With the React upgrade this turned into a type error. Can the ImgDepiction and SvgDepiction types be removed?
…39' into feature/replaceDeprecatedGuiComponents-CMEM-4905
…39' into feature/replaceDeprecatedGuiComponents-CMEM-4905
…to the icon correctly
- `searchListPredicate` property: Allows to filter the complete list of search options at once.
- Following optional BlueprintJs properties are forwarded now to override default behaviour: `noResults`, `createNewItemRenderer` and `itemRenderer`
- by default, if no searchPredicate or searchListPredicate is defined, the filtering is done via case-insensitive multi-word filtering.
- `searchPreficate`: replaced by the, in some cases, more efficient `searchListPredicate`
# Conflicts: # src/extensions/codemirror/CodeMirror.tsx
…eDeprecatedGuiComponents-CMEM-4905 # Conflicts: # CHANGELOG.md # src/cmem/ActivityControl/ActivityControlWidget.tsx # src/components/MultiSelect/MultiSelect.tsx
…edGuiComponents-CMEM-4905
…onents-CMEM-4905 Replace deprecated gui components (CMEM-4905)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made refactors to adapt for version 18 and even version 19.