Analyze SM log volume and reduce gcmgr noise (Change 1). - #466
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/v4.x #466 +/- ##
==============================================
Coverage ? 54.81%
==============================================
Files ? 39
Lines ? 6881
Branches ? 944
==============================================
Hits ? 3772
Misses ? 2707
Partials ? 402 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JacksonYao287
approved these changes
Sep 21, 2026
Besroy
added a commit
to Besroy/HomeObject
that referenced
this pull request
Sep 21, 2026
Co-authored-by: yawzhang <yawzhang@ebay.com>
Besroy
added a commit
to Besroy/HomeObject
that referenced
this pull request
Sep 21, 2026
Co-authored-by: yawzhang <yawzhang@ebay.com>
Besroy
added a commit
to Besroy/HomeObject
that referenced
this pull request
Sep 21, 2026
Co-authored-by: yawzhang <yawzhang@ebay.com>
Besroy
added a commit
that referenced
this pull request
Sep 21, 2026
* Fix snapshot receiver progress on replay Snapshot receiver progress could be counted repeatedly when a same-LSN baseline resync replayed shard metadata. Batch retries after a failed batch could also roll back the preceding batch contribution. Track the current shard contribution separately, reset it on shard replay, and clear stale batch rollback state when accepting a new batch. Also fixed a minor bug in the handling of unexpected blob corruption by returning after collecting detached futures. Reference: SDSTOR-24120 * Fix batch resend bug caused by prefetch limit (#454) Retained look-ahead data could exhaust the donor prefetch budget while rebuilding a resent batch, preventing a required earlier blob from being loaded and causing each retry to fail at the same cursor, sticking the resync progress at the same point. Allow blobs preceding the retained prefetch frontier to bypass the bounded look-ahead budget, and cover the scenario with a focused regression test. * Improve baseline resync logging (#455) Eliminate inconsistent terminology, context, and severity levels across existing BR read/write logs. Add structured lifecycle, payload, retry, and failure records with consistent PG, shard, batch, blob, and block identifiers. Keep key object and payload transitions at INFO while moving per-blob details to TRACE to reduce routine log noise. * Analyze SM log volume and reduce gcmgr noise (Change 1) (#466) Co-authored-by: yawzhang <yawzhang@ebay.com> --------- Co-authored-by: KOU Jilong <108138320+koujl@users.noreply.github.com> Co-authored-by: yawzhang <yawzhang@ebay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.