Target feature flags by stable team ID#514
Closed
matthewlouisbrockman wants to merge 2 commits into
Closed
Conversation
Remove dashboard slugs from the LaunchDarkly context so routing identifiers cannot become targeting inputs. Existing Dashboard project rules and targets use team context keys only.
Contributor
Author
|
eh, will wait to coordinate this, realized someone else had added this not me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
team.slugto LaunchDarklyWhy
Dashboard slugs are mutable routing identifiers, while the verified team ID is the stable LaunchDarkly targeting key. Keeping slug in the evaluation context allowed future rules to produce inconsistent results for the same team.
A read-only audit of the Dashboard LaunchDarkly project found no slug-based clauses or segments in Test, Staging, or Production. Existing team targets use team context keys with UUID team IDs, so this does not change current targeting behavior.
Validation
bunx vitest run tests/unit/feature-flags.test.ts tests/unit/sidebar.test.tsbun run next typegen && bunx tsc --noEmitbun run knip:cibunx react-doctor --verbose --diff origin/main --blocking warning --no-score --no-telemetry