feat: redesign git sidebar to 2-column layout#47
Open
mai1015 wants to merge 1 commit into
Open
Conversation
Replace the confusing 3-column diff view with a clearer 2-column layout showing removed lines on the left and added lines on the right. Adds a configurable git view layout preference. Closes duxweb#42 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
|
感谢这个 PR!两栏审查视图的方向我们认可(正是 #42 想要的),但有几个设计问题需要调整后才能合入,麻烦按下面意见修改并 rebase: 必须调整:
另外: main 最近把 改完我们优先 review。PR #48 的渲染修复已经以你的署名 cherry-pick 进 main 了,谢谢! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the git sidebar from a confusing 3-column layout to a clearer 2-column layout.
The original 3-column view mixed origin, removed lines, and modified results in a way that was hard to read. This PR changes it to:
Also adds a configurable git view layout preference in settings.
Closes #42
Changes
sidebars/git.rsto render a 2-column diff layoutgit_viewsetting module with layout preferencecodux-gitdiff/types/wire to support the new layoutTest plan