Skip to content

Include action name and form data in action approval emails - #15

Draft
suraj-ranganath wants to merge 1 commit into
mainfrom
suraj.ranganath/pylon-13007/action-approval-email-details
Draft

Include action name and form data in action approval emails#15
suraj-ranganath wants to merge 1 commit into
mainfrom
suraj.ranganath/pylon-13007/action-approval-email-details

Conversation

@suraj-ranganath

Copy link
Copy Markdown
Collaborator

Summary

Approver and requester emails for requestable actions were too generic to act on without opening the request. Approvers could not see the action being asked for, and requesters saw copy that just said an "action" was submitted.

This change:

  • Stores Action Name (from the tool catalog) and form data (submitted public arguments) on access requests
  • Renders both the approver email and the requester confirmation email from that payload
  • Omits the form-data section when no form was submitted
  • Redacts secret-like fields and HTML-escapes values
  • Shows Action Name, form data, and both email subjects on the existing approval cards so reviewers do not have to click through

Approver subject: Approval needed: {Action Name}
Requester subject: {Action Name} submitted for approval

Customer evidence

Testing

cd platform && python3 -m unittest test_action_request_emails.py

12 tests covering action names, form-data extraction/redaction, approver/requester copy, HTML escaping, and request enrichment.

Approver and requester emails for human-gated actions were generic
unless the reviewer opened the request. Persist Action Name plus
submitted form data on access requests, render both emails from that
payload, and surface the details in the control room.

Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant