Include action name and form data in action approval emails - #14
Draft
suraj-ranganath wants to merge 1 commit into
Draft
Include action name and form data in action approval emails#14suraj-ranganath wants to merge 1 commit into
suraj-ranganath wants to merge 1 commit into
Conversation
Requestable action approval emails were generic unless the approver opened the request. Persist Action Name and form data on the access request, and put both in the approver email, the requestor confirmation, and Slack copy. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requestable action/automation approval emails were too generic: approvers had to open the request to see what was asked for, and requestors only got a generic “your action is submitted” notice.
This change keeps the existing access-request approval flow and adds the customer-visible details from Pylon #13007:
Customer evidence
Test plan
python3 platform/test_action_approval_emails.pypython3 platform/test_mcp_gateway.pypython3 platform/test_runtime_execution.pypython3 demo/run_demo.py all