chore/mixed branch excluded work clean#100
Merged
Merged
Conversation
drmoisan
commented
Mar 26, 2026
drmoisan
commented
Owner
- fix: align codex web workflow with linux setup
- ci: run codex web setup test on branch updates
- (fix(concurrent-observable)): relay wrapper as CollectionChanged sender
- (fix(QfcItemController)): propagate OperationCanceledException from conversation load
- (fix(EfcHomeController)): guard ExecuteMovesAsync against re-entrant cleanup and fix metrics predicate
- (codex): convert feature review to codex skill and sub-agents
- (chore): upgrade ribbon
- bootstrap(ee92dd6): restore QfcHomeController.cs and missing-serializable-list.json
- bootstrap(a8d24b2): restore TaskMaster.csproj
- bootstrap(4634ac5): restore AppAutoFileObjects.cs
- fix(whitespace): normalize RibbonExplorer.xml indentation
- Update ConcurrentObservableBase to raise CollectionChanged with the wrapper instance for relayed view-model and base-collection events - Add regression tests covering add, remove, and concrete wrapper casting scenarios for ConcurrentObservableCollection subscribers - Include the new sender regression test file in the UtilitiesCS.Test project Refs: #87
…onversation load
- Add catch (OperationCanceledException) { throw; } before the broad
catch (System.Exception) so mid-load cancellation is not suppressed
- Extract ConversationResolver.LoadAsync into protected virtual
DoLoadConversationResolverCoreAsync to enable seam-based testing
without WinForms infrastructure
- Guard PopulateConversationAsync against null ConversationResolver
after a silently-swallowed load failure; add token check after load
- Add QfcItemControllerTests with four regression tests covering
cancellation propagation and null-guard paths
…cleanup and fix metrics predicate - Add `_isExecuting` volatile flag to drop re-entrant calls before any field access, preventing NullReferenceException when Cleanup() nulls _globals mid-await - Capture _globals into a local before MoveToFolderAsync as defense-in-depth against concurrent Cleanup() racing the post-await continuation - Fix inverted predicate in QuickFileMetrics_WRITE: `Count == 0` → `Count > 0` to write metrics for non-empty move results instead of empty ones - Add EfcHomeControllerTests with three regression tests covering the re-entrancy guard and both empty-list and null-list paths through QuickFileMetrics_WRITE
…d in another branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.