Skip to content

fix: preserve equals signs in loader argument values #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −1
Open

fix: preserve equals signs in loader argument values #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dyana/loaders/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _parse_arg_name_from(self, name: str, args: list[str]) -> str | None:
return arg

elif arg.startswith(f"{arg_name}="):
return arg.split("=")[1]
return arg.split("=", 1)[1]

return arg_name if found_pre else None

Expand Down
19 changes: 19 additions & 0 deletions dyana/loaders/settings_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,25 @@ def test_parse_args() -> None:
assert parsed_args[1] == ParsedArgument(name="data", value="/path/to/data", volume=True)


def test_parse_args_with_equals_in_value() -> None:
settings = LoaderSettings(
description="test loader", args=[LoaderArgument(name="package", description="Package expression")]
)

for args in (["--package", "offline-demo==1.2"], ["--package=offline-demo==1.2"]):
assert settings.parse_args(args) == [ParsedArgument(name="package", value="offline-demo==1.2")]


def test_parse_build_args_with_equals_in_value() -> None:
settings = LoaderSettings(description="test loader", build_args={"extra-requirements": "EXTRA_REQUIREMENTS"})

for args in (
["--extra-requirements", "offline-demo==1.2 another==2.3"],
["--extra-requirements=offline-demo==1.2 another==2.3"],
):
assert settings.parse_build_args(args) == {"EXTRA_REQUIREMENTS": "offline-demo==1.2 another==2.3"}


def test_parse_args_with_default() -> None:
settings = LoaderSettings(
description="test loader", args=[LoaderArgument(name="model", description="Model to use", default="gpt2")]
Expand Down
Loading