Repository navigation
Enhance linting setup and clarify SchedulingPolicy documentation - #696
Merged
Merged
Conversation
Add an actions/setup-go step to the lint workflow so the Go toolchain version matches the one declared in go.mod instead of relying on the runner's default, avoiding version mismatches during linting. Signed-off-by: Gaius <gaius.qi@gmail.com>
Reword the AUTO and ALWAYS comments so AUTO states that downloads bypass the scheduler when the content length or range length is at most 16MiB, replacing the vague "smaller than the minimum piece length" wording. The ALWAYS description is simplified to "even for small files". Generated Go and Rust bindings are regenerated to match the proto. Signed-off-by: Gaius <gaius.qi@gmail.com>
… length Update the SchedulingPolicy enum comments to describe the direct-download threshold in terms of the minimum piece length instead of a hardcoded 16MiB content/range length. Regenerate the descriptor accordingly. No functional behavior changes. Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
requested review from
CooooolFrog,
EvanCley,
Fricounet,
fcgxz2003,
hhhhsdxxxx and
yyzai384
November 5, 2026 06:19
gaius-qi
enabled auto-merge (squash)
November 5, 2026 06:20
CormickKneey
approved these changes
Nov 5, 2026
CormickKneey
left a comment
CormickKneey
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Lint workflow now pins Go from go.mod, and SchedulingPolicy AUTO/ALWAYS comments match the ≤16MiB content/range bypass used in client. Generated bindings look consistent. No functional concerns.
imeoer
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the download scheduling policy logic and ensures the Go environment is properly set up in the CI workflow. The most significant changes clarify when downloads should bypass the scheduler and improve the reliability of Go-based linting in CI.
Scheduling Policy Documentation Updates:
SchedulingPolicycomments in bothproto/common.protoandsrc/common.v2.rsto specify that downloads will bypass the scheduler if the content length or range length is less than or equal to 16MiB, instead of referencing the minimum piece length. This change clarifies the conditions under which direct downloads occur. [1] [2]CI Workflow Improvements:
.github/workflows/lint.ymlworkflow to set up the Go environment using theactions/setup-go@v7action, ensuring the correct Go version fromgo.modis used during linting.Related Issue
Motivation and Context