Skip to content

Consumer: drop max_version clamp on ListOffsetsRequest #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
May 28, 2026
+0 −8
Merged

Consumer: drop max_version clamp on ListOffsetsRequest #3012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions kafka/consumer/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,13 +747,6 @@ async def _send_list_offsets_request(self, node_id, timestamps_and_epochs):
Raises:
TopicAuthorizationFailedError: if any topic returned an auth error
"""
# TODO:
# v6 flexible
# v7 MAX_TIMESTAMP (KIP-734)
# v8 EARLIEST_LOCAL (KIP-405)
# v9 LATEST_TIERED (KIP-1005)
# v10 async remote (KIP-1075)
max_version = 5
min_version = 1 if any(res[0] >= 0 for res in timestamps_and_epochs.values()) else 0
min_version = max(min_version, ListOffsetsRequest.min_version_for_isolation_level(self._isolation_level))
by_topic = collections.defaultdict(list)
Expand All @@ -768,7 +761,6 @@ async def _send_list_offsets_request(self, node_id, timestamps_and_epochs):
isolation_level=self._isolation_level,
topics=list(by_topic.items()),
min_version=min_version,
max_version=max_version,
)

log.debug("Sending ListOffsetRequest %s to broker %s", request, node_id)
Expand Down
Loading