Fix The nodes of TreeView not in dark mode when editing it#14787
Open
Sathish-087 wants to merge 3 commits into
Open
Fix The nodes of TreeView not in dark mode when editing it#14787Sathish-087 wants to merge 3 commits into
Sathish-087 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12042
Proposed changes
WM_CTLCOLOREDITinTreeView.WndProcfor the native in-place node label edit control.WM_CTLCOLOREDITinListView.WndProcfor the native in-place item label edit control to maintain consistent dark-mode behavior.InitializeDCForWmCtlColorinfrastructure to apply the correct foreground and background colors to the native edit control during label editing.Customer Impact
Regression?
Risk
WM_CTLCOLOREDITpath for native label-edit controls and reuses the existingInitializeDCForWmCtlColorimplementation already used throughout WinForms color initialization logic.Screenshots
Before
TreeViewEditIssue.mp4
After
TreeViewEditFixDemo.mp4
Test methodology
TVN_BEGINLABELEDITWcreates a native edit control and thatWM_CTLCOLOREDITis raised by the edit control during painting.WM_CTLCOLOREDITtoInitializeDCForWmCtlColorcorrectly applies the control'sForeColorandBackColor.TreeViewandListViewunder dark mode and verified that text and background colors match the parent control.Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow