Centralize feature prompts by target release#14767
Merged
KlausLoeffelmann merged 1 commit intoJul 23, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 27022e2a-9eb8-4f58-9bfa-e79ca0d6c559
KlausLoeffelmann
enabled auto-merge (squash)
July 23, 2026 02:05
|
|
||
| ## 6. Supersede the piecemeal APIs | ||
|
|
||
| - `Application.GetWindowsAccentColor` → `Application.SystemVisualSettings.AccentColor`. The method |
Member
There was a problem hiding this comment.
The Application.WindowsAccentColor.cs file should have been removed during the iteration process; that content is effectively obsolete.
Member
Author
There was a problem hiding this comment.
Same thing: This is a snap-shot in time, and should be captured as it was.
If you agree, can you approve?
If not, let's discuss! :-)
| factor (1.0–2.25; i.e. `TextScaleFactor / 100`). **Live getter** — re-reads the value, does | ||
| not cache, because it is a system setting that changes at runtime. Well-defined regardless | ||
| of whether any `Form` exists or how many UI threads are running (it is process-global). | ||
| - **`public static SystemTextSizeAwareness SystemTextSizeAwareness { get; set; }`** — the |
Member
There was a problem hiding this comment.
The file SystemTextSizeAwareness removed during iteration.
|
|
||
| ### `Form` (instance) | ||
|
|
||
| - **`public event EventHandler? SystemTextSizeChanged`** — instance event, raised on each |
Member
There was a problem hiding this comment.
The file Form.SystemTextSize.cs removed during iteration.
|
|
||
| **Source of the original implementation (pinned):** `KlausLoeffelmann/winforms` @ `cf32e9c4efeba9d77e1a14025a8590b104e3c705` (old `/src/System.Windows.Forms/src/...` layout; `TextBoxBase.cs` ≈ 2562 lines). Relevant files: | ||
| - `.../Controls/TextBox/TextBoxBase.cs` — NC paint, NC calc, focus invalidation, `GetVisualStylesPadding`, helpers. | ||
| - `.../Controls/TextBox/TextBoxBase.NonClientBitmapCache.cs` — the offscreen cache class. |
Member
There was a problem hiding this comment.
This file does not exist on the Net11/Integration-4 branch.
SimonZhao888
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14766.
Summary
.github/Feature-PromptsApplication.SystemTextAwarenessfolder name in.github/Feature-Prompts.This is a documentation-only change.
Microsoft Reviewers: Open in CodeFlow