Fix DataGridViewCheckBoxCell error icon suppression in edit mode#14747
Open
KSaiSivani wants to merge 2 commits into
Open
Fix DataGridViewCheckBoxCell error icon suppression in edit mode#14747KSaiSivani wants to merge 2 commits into
KSaiSivani wants to merge 2 commits into
Conversation
KSaiSivani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1929
Proposed changes
Removed suppression logic that hid the error icon when a DataGridViewCheckBoxCell was the current cell in edit mode.
Added unit tests (DataGridViewCheckBoxCell_ErrorIconBounds_RemainsVisible_InEditMode) to validate that error icons remain visible when the cell is selected, focused, and in edit mode.
Customer Impact
Regression?
Risk
Screenshots
Before
Error icon disappears when checkbox cell is selected.
CheckBoxCell_BeforeFix.mp4
After
Error icon remains visible when checkbox cell is selected.
CheckBoxCell_AfteFix.mp4
Test methodology
Added targeted unit tests for DataGridViewCheckBoxCell error icon visibility in edit mode.
Verified error icon remains visible across selection, focus, toggle, and edit scenarios.
Test environment(s)
Microsoft Reviewers: Open in CodeFlow