Remove obsolete native managed-invocation machinery - #133660
Draft
jkoritzinsky wants to merge 1 commit into
Draft
Conversation
Delete MethodDescCallSite, CallDescrWorker and their argument-copying, return-value, architecture assembly, build, and EH identification closure after the reflection, custom-attribute, and func-eval migrations. Remove orphaned multicore-JIT diagnostic state and update VM-to-managed calling documentation. Preserve live field-access helpers, typed UCO calls, GC argument reporting, and calling-convention traits. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jkoritzinsky
added this pull request to stack #133661
September 11, 2026 03:04
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Sep 11, 2026
jkoritzinsky
removed this pull request from stack #133661
September 11, 2026 03:11
jkoritzinsky
added this pull request to stack #133663
September 11, 2026 03:11
Contributor
|
Tagging subscribers to this area: @agocke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer 4 of the stack for #123864, following #133659. Remove the native machinery whose final callers disappeared in the preceding reflection, custom-attribute, and func-eval layers.
MethodDescCallSite,CallDescrData,CallDescrWorker,DispatchCallSimple, and their argument/return-value copying closure.Retained: live
InvokeUtilfield/pointer/conversion/exception helpers,UnmanagedCallersOnlyCaller, default-constructor dispatch,ArgDestinationGC reporting, profiler/calling-convention logic, and debugger raw-result storage. Historical stack traces are left intact.The layer removes about 2,900 net lines across 49 files.
Validation
The tested binaries were built from the identical final working tree before the cleanup commit, so their embedded native version identifies the parent commit. Actual Linux, ARM/ARM64, and WebAssembly runtime execution was not performed.
Stack created with GitHub Stacks CLI • Give Feedback 💬
Note
This PR description and cleanup were prepared with GitHub Copilot.