Skip LCG Jump-Stub Validation In Rundown Validation Test Under Interpreter Mode - #133650
Open
brianrob wants to merge 1 commit into
Open
Skip LCG Jump-Stub Validation In Rundown Validation Test Under Interpreter Mode#133650brianrob wants to merge 1 commit into
brianrob wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review tier: Lite
Findings: None
What changed in this PR
Updates the rundown validation test to skip only the JIT-specific LCG unload check in CoreCLR interpreter mode while preserving general validation.
Changes:
- Adds an interpreter-mode guard for LCG validation.
- Retains supported JIT and general rundown checks.
| File | Description |
|---|---|
src/tests/tracing/eventpipe/rundownvalidation/rundownvalidation.cs |
Gates LCG jump-stub unload validation for interpreter runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interpreter can create a jump-stub load without releasing the collectible dynamic-method state during the test's collection window. This makes the JIT-specific unload assertion inapplicable rather than indicating missing rundown events.
Fixes #133280
Note
This pull request description was generated with GitHub Copilot.