[release/10.0] Fix NoopLimiter disposal in DefaultPartitionedRateLimiter Heartbeat - #133647
Open
github-actions[bot] wants to merge 1 commit into
Open
[release/10.0] Fix NoopLimiter disposal in DefaultPartitionedRateLimiter Heartbeat#133647github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…127582) Fixes `DefaultPartitionedRateLimiter` so that `NoopLimiter` partitions are evicted and disposed by the Heartbeat timer, which previously never happened because `NoopLimiter.IdleDuration` always returns `null`. ## Changes Made - Introduced a `LimiterEntry` wrapper that tracks a `LastAccessTimestamp` (updated on each `Acquire`/`WaitAsync` call) alongside the `RateLimiter` instance. - Added `GetIdleDuration(LimiterEntry)` helper that falls back to the elapsed time since last access for `NoopLimiter` (whose `IdleDuration` is always `null`), and returns `null` for all other limiter types that return `null` (preserving the existing "do not evict" contract). - Updated the Heartbeat eviction check to use the `is TimeSpan idleDuration && idleDuration > s_idleTimeLimit` pattern (with `?? TimeSpan.Zero` for the under-lock re-check), correctly handling the nullable `TimeSpan?` return — `null` skips eviction, matching the original pattern. - Used `Volatile.Read`/`Volatile.Write` for atomic 64-bit timestamp access on 32-bit platforms. - Added a `RateLimiterHelper.GetElapsedTime(long)` overload to avoid `.GetValueOrDefault()` at call sites. - Added tests covering `NoopLimiter` eviction via Heartbeat and verifying that non-`NoopLimiter` partitions with `IdleDuration == null` are not evicted while active. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: VSadov <8218165+VSadov@users.noreply.github.com> Co-authored-by: Vladimir Sadov <vsadov@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #127582 to release/10.0
/cc @agocke @copilot
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.