Make ordinary FCALL contracts nothrow - #133644
Draft
davidwrighton wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c7ffdbd-30b8-43ca-9c02-936ca602170c
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
jkotas
approved these changes
Sep 10, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c7ffdbd-30b8-43ca-9c02-936ca602170c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FCALL_CHECKand ordinaryFCALL_CONTRACTstatically and dynamicallyNOTHROW/GC_NOTRIGGERFCALL_CONTRACT_WITH_FRAMEfor FCALLs that explicitly establish a frame before exception dispatchIL_Throw,IL_Rethrow, andIL_ThrowExact, including their WASM wrappersMethodDesc::GetName()contract toNOTHROW; the parameterless overload only returns stored names or converts metadata lookup failures tonullptrThe FCALL audit found only the three IL exception helpers directly enabling GC or dispatching managed exceptions. This draft is intended to validate the stronger dynamic contract across the full CI matrix.
Validation
build.cmd clr -rc checkedBroad local testing was intentionally skipped in favor of the CI matrix.
Note
This pull request description was generated with GitHub Copilot.