-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Handle read-only /tmp and missing NUMA/robust-mutex on HarmonyOS #132827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
springmin
wants to merge
5
commits into
dotnet:main
Choose a base branch
from
springmin:pr/ohos-sandbox-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1e8807e
Handle read-only /tmp and missing NUMA/robust-mutex on HarmonyOS
springmin 1d205c6
Merge branch 'main' into pr/ohos-sandbox-fixes
springmin c008574
Scope shared-memory path change to HarmonyOS and keep NamedMutex test…
springmin 9551262
Rename TargetsLinuxOhos to TargetsOhos to match TARGET_OHOS convention
springmin cc9ccb3
Rename OHOS identifiers to OPENHARMONY per review feedback
springmin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -220,6 +220,17 @@ internal static bool IsHaiku() => | |
| false; | ||
| #endif | ||
|
|
||
| /// <summary> | ||
| /// Indicates whether the current application is running on HarmonyOS (OpenHarmony). | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. HarmonyOS is not the same as OpenHarmony. Should all comments like this talk just about OpenHarmony? |
||
| /// </summary> | ||
| [NonVersionable] | ||
| internal static bool IsOpenHarmony() => | ||
| #if TARGET_OPENHARMONY | ||
| true; | ||
| #else | ||
| false; | ||
| #endif | ||
|
|
||
| /// <summary> | ||
| /// Indicates whether the current application is running on Android. | ||
| /// </summary> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TargetOpenHarmony->TargetsOpenHarmonyto match the naming pattern