Produce deprecated property in JsonSchema for obsolete types by Youssef1313 · Pull Request #130665 · dotnet/runtime

Youssef1313 · 2026-07-14T06:41:15Z

Spec: https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-01#section-9.3

Copilot

Pull request overview

This PR updates the System.Text.Json JSON Schema exporter to emit the JSON Schema deprecated keyword when exporting schemas for [Obsolete] .NET types, and adds a regression test covering the new behavior.

Changes:

Detect [Obsolete] on exported types and set deprecated: true in the generated schema.
Add Deprecated support to the internal JsonSchema model and include it in JSON output.
Add a unit test validating deprecated is emitted for an obsolete type.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs	Adds a test case validating `deprecated` is produced for an `[Obsolete]` type.
src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs	Marks exported schemas as deprecated when the associated .NET type has `[Obsolete]`.
src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchema.cs	Adds a `Deprecated` keyword to the schema model, counts it, and emits it during JSON serialization.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

dotnet-policy-service · 2026-07-14T06:54:30Z

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

eiriktsarpalis

Thanks

Copilot AI review requested due to automatic review settings July 14, 2026 06:41

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:41 — with GitHub Actions Inactive

github-actions Bot added the area-System.Text.Json label Jul 14, 2026

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:41 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 14, 2026 06:41 View session

Youssef1313 had a problem deploying to copilot-pat-pool July 14, 2026 06:42 — with GitHub Actions Failure

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:43 — with GitHub Actions Inactive

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:44 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Copilot AI review requested due to automatic review settings July 14, 2026 06:50

Youssef1313 force-pushed the dev/ygerges/deprecated-schema branch from 2e895bf to a5d6c2d Compare July 14, 2026 06:50

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:50 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 14, 2026 06:50 View session

Youssef1313 force-pushed the dev/ygerges/deprecated-schema branch from a5d6c2d to 0460d8b Compare July 14, 2026 06:51

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:51 — with GitHub Actions Inactive

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:52 — with GitHub Actions Inactive

Youssef1313 had a problem deploying to copilot-pat-pool July 14, 2026 06:53 — with GitHub Actions Failure

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:54 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs Outdated

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Copilot AI review requested due to automatic review settings July 14, 2026 06:54

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:54 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 14, 2026 06:54 View session

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 06:54 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs Outdated

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Copilot AI review requested due to automatic review settings July 14, 2026 07:01

Youssef1313 force-pushed the dev/ygerges/deprecated-schema branch from 0460d8b to 76a2de7 Compare July 14, 2026 07:01

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 07:01 — with GitHub Actions Inactive

eiriktsarpalis reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

Address review comments

a1e1d38

This was referenced Jul 14, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

Handle properties, add tests

a668165

Copilot AI review requested due to automatic review settings July 14, 2026 13:17

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 13:17 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 14, 2026 13:17 View session

Youssef1313 had a problem deploying to copilot-pat-pool July 14, 2026 13:18 — with GitHub Actions Failure

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 13:19 — with GitHub Actions Inactive

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 13:20 — with GitHub Actions Inactive

Youssef1313 requested a review from eiriktsarpalis July 14, 2026 13:20

Youssef1313 temporarily deployed to copilot-pat-pool July 14, 2026 13:21 — with GitHub Actions Inactive

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs

eiriktsarpalis reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/tests/Common/JsonSchemaExporterTests.cs Outdated

eiriktsarpalis reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs

This was referenced Jul 14, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

[wasm] OpenQA.Selenium.WebDriverTimeoutException: timeout: Timed out receiving message from renderer #117486

Open

Assert complete schema

f356da1

Copilot AI review requested due to automatic review settings July 15, 2026 08:23

Youssef1313 temporarily deployed to copilot-pat-pool July 15, 2026 08:24 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Youssef1313 July 15, 2026 08:24 View session

Youssef1313 had a problem deploying to copilot-pat-pool July 15, 2026 08:25 — with GitHub Actions Failure

Youssef1313 temporarily deployed to copilot-pat-pool July 15, 2026 08:26 — with GitHub Actions Inactive

Youssef1313 temporarily deployed to copilot-pat-pool July 15, 2026 08:27 — with GitHub Actions Inactive

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread src/libraries/System.Text.Json/src/System/Text/Json/Schema/JsonSchemaExporter.cs

eiriktsarpalis approved these changes Jul 15, 2026

View reviewed changes

Uh oh!

Conversation

Youssef1313 commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dotnet-policy-service Bot commented Jul 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

eiriktsarpalis left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants