Pass down DJI and MethodDesc to avoid unnecessary PtrHashMap lookup#130539
Open
hoyosjs wants to merge 1 commit into
Open
Pass down DJI and MethodDesc to avoid unnecessary PtrHashMap lookup#130539hoyosjs wants to merge 1 commit into
hoyosjs wants to merge 1 commit into
Conversation
(cherry picked from commit be7a57d)
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
steveisok
approved these changes
Jul 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreCLR’s debugger patch binding path to pass already-available DebuggerJitInfo* and MethodDesc* into CodeRegionInfo::GetCodeRegionInfo when computing the target patch address, avoiding the fallback path that derives region info from the start address alone.
Changes:
- In
DebuggerController::BindPatch, callCodeRegionInfo::GetCodeRegionInfo(info, pMD, startAddr)instead ofGetCodeRegionInfo(NULL, NULL, startAddr)soGetCodeRegionInfocan immediately return cached region info wheninfo->m_addrOfCodeis present. - Keeps the binding logic consistent with
GetCodeRegionInfo’s contract (whenaddris provided, it asserts it matchesGetFunctionAddress(md)), sincestartAddrhere is sourced fromDebuggerJitInfo::m_addrOfCode/GetCodeForInterpreterOrJitted().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ports the fix from #126247 to
main.DebuggerController::BindPatchalready has theDebuggerJitInfoandMethodDescneeded byCodeRegionInfo::GetCodeRegionInfo, so this change passes them through instead of forcing the fallback lookup path.That keeps
mainaligned with the servicing fix and avoids an unnecessaryPtrHashMaplookup while binding patches insrc/coreclr/debug/ee/controller.cpp.Note
This PR description was generated with GitHub Copilot.