Skip to content

Use impInlineRoot()->compIsAsync() in fgGetStaticsCCtorHelper #130536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Use impInlineRoot()->compIsAsync() in fgGetStaticsCCtorHelper #130536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/jit/flowgraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ GenTreeCall* Compiler::fgGetStaticsCCtorHelper(CORINFO_CLASS_HANDLE cls, CorInfo
// across suspensions" behavior for free, while also properly
// ensuring derived addresses are byref typed and are treated
// similarly.
type = compIsAsync() ? TYP_BYREF : TYP_I_IMPL;
type = impInlineRoot()->compIsAsync() ? TYP_BYREF : TYP_I_IMPL;

@AndyAyersMS AndyAyersMS Jul 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to do this inside compIsAsync; I do this sort of thing elsewhere in the JIT, for things like this that might be called in early phases.

@jakobbotsch jakobbotsch Jul 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Often we don't actually want this to be true inside the inlinee unless the inlinee is itself async. But this case is an exception.

break;

case CORINFO_HELP_INITCLASS:
Expand Down
Loading