JIT: Coalesce stores from struct copies#130535
Draft
EgorBo wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f267b92e-719f-4b0d-b19f-eab8f97611f5
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates JIT copy-block morphing so that when a struct copy is expanded into multiple field stores, the non-GC field STOREIND nodes are marked with GTF_IND_ALLOW_NON_ATOMIC. This enables existing lowering-time store coalescing to legally merge adjacent non-volatile stores (e.g., two 8-byte stores into one 16-byte SIMD store) without being blocked by atomicity constraints.
Changes:
- In
MorphCopyBlockHelper::CopyFieldByField, mark per-field indirect stores asGTF_IND_ALLOW_NON_ATOMICwhen they originate from acopyBlkand the field type is not GC (!varTypeIsGC(srcType)). - This allows Lowering’s store coalescing (
LowerStoreCoalescing/LowerCheckCoalescedStoreAtomicity) to treat these adjacent stores as eligible for wider, potentially unaligned, non-atomic combined stores.
Member
Author
|
@MihuBot -nuget |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows existing store coalescing to merge non-GC field stores produced by struct copies.