-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Document that BpeOptions.ByteLevel requires a PreTokenizer #7716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zpczpc
wants to merge
1
commit into
dotnet:main
Choose a base branch
from
zpczpc:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,6 +143,14 @@ public BpeOptions(string vocabFile, string? mergesFile = null) | |
| /// if true, the input text will be converted to UTF-8 bytes before encoding it. | ||
| /// Additionally, some ASCII characters will be transformed to different characters (e.g Space character will be transformed to 'Ġ' character). | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// Byte-level encoding is normally paired with a byte-level pre-tokenizer. When this property is set to | ||
| /// <see langword="true"/>, <see cref="PreTokenizer"/> must be set as well. | ||
| /// On its own, byte-level encoding maps the space character to 'Ġ' but does not keep the whitespace attached | ||
| /// to the following token, so spaces and newlines are dropped during encoding and cannot be recovered by decoding. | ||
| /// Configuring a byte-level pre-tokenizer, for example <see cref="RegexPreTokenizer"/> built from the GPT-2 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we limit this claim to preserving whitespace during pre-tokenisation? Normalisation and missing vocabulary entries can still change or discard input, so the GPT-2 regex alone cannot guarantee a lossless round trip. |
||
| /// pattern, makes the round trip lossless. | ||
| /// </remarks> | ||
| public bool ByteLevel { get; set; } | ||
|
|
||
| /// <summary> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we describe the default pre-tokeniser’s behaviour rather than make this a requirement of
ByteLevel?